Compression UI utilities #683
Conversation
Removed UIManager dependencies.
|
Failing test |
There was a problem hiding this comment.
Looks like this approach will work better, but I'll wait for @estebanlm here :)
This adds a dependency from NewTools to Compression, which is understandable to me, and could be further refactored later. But maybe Esteban is thinking on a different package/project/repo organization.
|
This looks good to me because the UI and core of compression have been separated. |
|
This is strange that we still get this traits fileout bug |
Yes, I have to unselect definitions from Iceberg before commiting but some can slip away :( |
|
Seems my PR solving that was not yet integrated :) There is an issue and I have to check it. |
Ducasse
requested review from
estebanlm
and removed request for
MarcusDenker
|
I can't be sure the remaining error is because of the PR or inherited. |
I re-run the job to see if we can discard the second option.
Could you also give us your opinion on the issue and the package structure here? |
|
yeah, is ok. I would not use a symbol to declare a group because it is not how the other groups are defined, but that is just a detail. |
| @@ -0,0 +1,26 @@ | |||
| Extension { #name : 'InflateStream' } | |||
|
|
|||
| { #category : '*NewTools-Compression-Utils' } | |||
There was a problem hiding this comment.
Now that this method was moved here, is there a "sister" PR in the Pharo repository removing the extension from there?
There was a problem hiding this comment.
Ok, if there's no rush I will check it later today since now I'm about to start a meeting
There was a problem hiding this comment.
Sure, it's not for yesterday :)
| extent: 600 @ 800 ] | ||
| ] | ||
|
|
||
| { #category : '*NewTools-Compression-Utils' } |
| @@ -0,0 +1,18 @@ | |||
| Extension { #name : 'ZipArchive' } | |||
|
|
|||
| { #category : '*NewTools-Compression-Utils' } | |||
|
Thanks @estebanlm ! I'll merge! |
Re-take of PR's causing dependency problems in the build.
In this PR, a new package is proposed:
NewTools-Compression-Utils.The new package includes a couple of minimal method to add open directory dialog to Compression classes.
It also removes the UIManager dependency from Compression.
These changes were the same as the previous PR's, but does instead of using the SpApplication hook, it uses directly the new FileBrowser API.